ThunderNFT’s up to date codebase can be found at [https://github.com/ThunderFuel/smart-contracts/tree/main/contracts-v1](https://github.com/ThunderFuel/smart-contracts/tree/main/contracts-v1).

__Whitehat Educational Resources & Technical Info__

**Is this an upgrade of an existing system? If so, which? And what are the main differences?**

The system takes reference from LooksRare v.1. Kinda an upgrade. Not an exact fork, the architecture logic is a fork. ~50% of it is a fork. Only borrows from LooksRare.

The big differences are the onchain part, listing/bidding/making offers/etc are all onchain, for LooksRare this is offchain. There is no wETH. Instead it implements a pool similar to Blur.

NFTs on Fuel are native assets on Fuel. Unlike on other marketplaces, NFTs need to be deposited into smart contracts.

**Where do you suspect there may be bugs? Useful aspects of this question are:**

- **Which parts of the code are you most concerned about?**
- **What attack vectors are you most concerned about?**
- **Which part(s) of the system do you want whitehats to attempt to break the most?**
- **Are there any assumed invariants that you want whitehats to attempt to break?**

Bugs related to when users need to deposit NFTs into the smart contracts. This is new and could have bugs because of its newness.

There could be a bug related to the distribution of royalties in the Royalty Manager contract.

Mostly concerned about an attack vector in Pool contract where users deposit ETH for bidding. And also, most concerned about Thunder Exchange contract where users deposit their NFTs into this contract for listing.

**What monitoring systems may you want to use as a reason to invalidate or downgrade an otherwise valid bug report?**

No, ThunderNFT doesn’t rely solely on monitoring, they want to reward bugs for being solved.

**What external dependencies are there?**

Sway libraries & standards

**Are there any unusual points about your protocol that may confuse whitehats?**

Sway language.
NFTs as a native assets like ETH. More information on this: https://docs.fuel.network/docs/sway/blockchain-development/native_assets/ 
Every action on the marketplace is onchain such as listing, offer, cancel listing/offer, etc. which is different from other marketplaces like OpenSea or LooksRare
Fuel Scripts that execute order-book listings & transactions, which bundle many txs into one. Resource on Fuel Scripts: https://docs.fuel.network/docs/sway/sway-program-types/scripts/ 

**What is the test suite setup information?**

[https://docs.fuel.network/docs/sway/testing/](https://docs.fuel.network/docs/sway/testing/)

**Public Disclosure of Known Issues**

Bug reports covering previously-discovered bugs (listed below) are not eligible for a reward within this program. This includes known issues that the project is aware of but has consciously decided not to “fix”, necessary code changes, or any implemented operational mitigating procedures that can lessen potential risk. 
- In the Thunder Exchange contract, cancel_order function does not revert if the order already cancelled.
- MakerOrder (an order used for listing/offer) has an expiration range. It may lead to stuck of deposited NFTs. Anything related to expiration of a MakerOrder (e.g. start_time, end_time, setter functions) will be removed later on. All associated reports will be considered as out-of-scope.
- Contracts outside of the Thunder Exchange cannot interact with the platform’s contract for listing, purchaing, etc. Only Addresses can.
- `withdraw_all` function  in the pool contract may revert/break. Will be removed. All associated reports will be considered as out-of-scope.


**Previous Audits**

ThunderNFT did not have any audits to this date. 

**Asset Accuracy Assurance**

Bugs found on assets incorrectly listed in-scope will be considered valid and be rewarded.

**Private Known Issues Reward Policy**

Private known issues, meaning known issues that were not publicly disclosed, are valid for a reward.

**Known Issue Assurance**

ThunderNFT commits to providing Known Issue Assurance to bug submissions through their program. This means that ThunderNFT will either disclose known issues publicly, or at the very least, privately via a self-reported bug submission. 

In a potential scenario of a mediation, this allows for a more objective and streamlined process, in order to prove that an issue is known. Otherwise, assuming the bug report is valid, it would result in the report being considered as in-scope, and due a reward.

**Primacy of Impact vs Primacy of Rules**

ThunderNFT adheres to the Primacy of Impact for all impacts.

Primacy of Impact means that the impact is prioritized rather than a specific asset. This encourages security researchers to report on all bugs with an in-scope impact, even if the affected assets are not in scope. For more information, please see [Best Practices: Primacy of Impact](https://immunefisupport.zendesk.com/hc/en-us/articles/12340245635089-Best-Practices-Primacy-of-Impact).

When submitting a report on Immunefi’s dashboard, the security researcher should select the Primacy of Impact asset placeholder. If the team behind this project has multiple programs, those other programs are not covered under Primacy of Impact for this program. Instead, check if those other projects have a bug bounty program on Immunefi.

If the project has any testnet and/or mock files, those will not be covered under Primacy of Impact.

All other impacts are considered under the Primacy of Rules, which means that they are bound by the terms and conditions set within this program

Solosync6

zeroK

NinetyNineCrits

SimaoAmaro

jecikpo

Blockian

jasonxiale

bugtester

Schnilch

anatomist

InquisitorScythe

https://drive.google.com/file/d/1Vp9FnQGPurPR1urKfcidAVZfQeIn49IF/view?usp=sharing

**ThunderNFT's Invite-Only Program is a form of Audit Competition which is exclusively accessible to a select group of security researchers who have submitted at least 1 valid report during Fuel Attackathon event. These researchers will share a flat reward pool for every valid bug found.**

Contract fails to deliver promised returns, but doesn't lose value

Theft of unclaimed royalties

Permanent freezing of unclaimed royalties

Temporary freezing of funds for at least 1 hour

Temporary freezing of NFTs for at least 1 hour

Smart contract unable to operate due to lack of token funds

Block stuffing

Griefing (e.g. no profit motive for an attacker, but damage to the users or the protocol)

Theft of gas

Unbounded gas consumption

Direct theft of any user funds, whether at-rest or in-motion, other than unclaimed yield

Direct theft of any user NFTs, whether at-rest or in-motion, other than unclaimed royalties

Permanent freezing of funds

Permanent freezing of NFTs

Unauthorized minting of NFTs

Predictable or manipulable RNG that results in abuse of the principal or NFT

Unintended alteration of what the NFT represents (e.g. token URI, payload, artistic content)

Protocol insolvency

**Proof of Concept (PoC) Requirements**

A PoC, demonstrating the bug's impact, is required for this program and has to comply with the [Immunefi PoC Guidelines and Rules](https://immunefisupport.zendesk.com/hc/en-us/articles/9946217628561-Proof-of-Concept-PoC-Guidelines-and-Rules).

**Eligibility Criteria**

Security researchers who wish to participate must adhere to the rules of engagement set forth in this program and cannot be:
- On OFACs SDN list 
- Official contributor, both past or present
- Employees and/or individuals closely associated with the project 
- Security auditors that directly or indirectly participated in the audit review

__Responsible Publication__

Whitehats may publish their bug reports after they have been fixed & paid, or closed as invalid, with the following exceptions:
- Bug reports in mediation may not be published until mediation has concluded and the bug report is resolved.

Immunefi may publish bug reports submitted to this audit competition and a leaderboard of the participants and their earnings.

__Feasibility Limitations__

The project may be receiving reports that are valid (the bug and attack vector are real) and cite assets and impacts that are in scope, but there may be obstacles or barriers to executing the attack in the real world. In other words, there is a question about how feasible the attack really is. Conversely, there may also be mitigation measures that projects can take to prevent the impact of the bug, which are not feasible or would require unconventional action and hence, should not be used as reasons for downgrading a bug's severity.

Therefore, Immunefi has developed a set of [feasibility limitation standards](https://immunefisupport.zendesk.com/hc/en-us/articles/16913132495377-Feasibility-Limitation-Standards) which by default states what security researchers, as well as projects, can or cannot cite when reviewing a bug report.

__Immunefi Standard Badge__

By adhering to Immunefi’s best practice recommendations, Ionic has satisfied the requirements for the [Immunefi Standard Badge](https://immunefisupport.zendesk.com/hc/en-us/articles/15006865432209-The-Immunefi-Standard-Badge).

The following reward terms are a summary, for the full details read our [ThunderNFT Audit Competition Reward Distribution Terms](https://immunefisupport.zendesk.com/hc/en-us/articles/27472225154577-ThunderNFT-IOP-Audit-Competition-Reward-Terms). 

A reward pool of $65,000 USD will be distributed among participants, even if no valid bugs are found. 

Duplicates and private known issues are valid for a reward.

Rewards are distributed according to the impact of the vulnerability based on the [Immunefi Vulnerability Severity Classification System V2.3](https://immunefi.com/immunefi-vulnerability-severity-classification-system-v2-3/).

Rewards will be distributed all at once based on Immunefi’s distribution formula after the event has concluded and the final bug reports have been resolved.

__Insight Rewards Payment Terms__

Insight Rewards: Portion of the Rewards Pool

* The "Insight" severity was introduced on Audit Competition & Attackathon programs to recognize contributions that extend beyond identifying immediate vulnerabilities. Currently, it's not an option to select the Insight severity when submitting a report. However, our team or program will designate it accordingly if applicable. "Insights" underscores our commitment to valuing all types of contributions that contribute to a more secure environment and will always be rewarded. [View more information about Insights](https://immunefisupport.zendesk.com/hc/en-us/articles/13333032674961-Severity-Classification-System?utm_source=immunefi)

NAME	EARNINGS	TOTAL VALID BUGS	CRITICAL	HIGH	MEDIUM/LOW	INSIGHTS
1 Solosync6	$17,057	1	1	0	0	0
2 zeroK	$10,573	7	0	3	4	1
3 NinetyNineCrits	$8,409	5	2	2	1	0
4 SimaoAmaro	$6,595	3	2	1	0	0
5 jecikpo	$5,270	8	1	2	5	0
6 Blockian	$3,899	4	2	0	2	1
7 jasonxiale	$3,300	5	2	1	2	0
8 bugtester	$2,951	1	0	0	1	2
9 Schnilch	$2,331	2	2	0	0	0
10 anatomist	$2,331	2	2	0	0	0
11 InquisitorScythe	$1,435	3	1	0	2	0
12 rbz	$848	0	0	0	0	1

IOP | ThunderNFT

Status

Status